Document more explicitly the dictionary zero element requirement. #711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now we have a comment to the dictionary proto and a comment to the string_table field. This requirement is important enough I think that it's worth documenting it more explicitly, especially the part that even if there are no references to the particular dictionary, the zero index element must still be present.
|
@open-telemetry/profiling-approvers |
christos68k
approved these changes
Sep 4, 2025
bogdandrutu
reviewed
Sep 4, 2025
jhalliday
approved these changes
Sep 5, 2025
florianl
approved these changes
Sep 9, 2025
tigrannajaryan
approved these changes
Sep 13, 2025
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we have a comment to the dictionary proto and a comment to the string_table field. This requirement is important enough I think that it's worth documenting it more explicitly, especially the part that even if there are no references to the particular dictionary, the zero index element must still be present.