-
Notifications
You must be signed in to change notification settings - Fork 296
Make the spec readme the entry point for website #680 #681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Make the spec readme the entry point for website #680 #681
Conversation
7f8eedb to
3856203
Compare
a42d655 to
58ecc45
Compare
Co-authored-by: Florian Lehner <[email protected]>
58ecc45 to
a139800
Compare
|
@open-telemetry/docs-approvers could you please take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm overall, but I assume we might need to do some rewiring on the oteldotio repo as well, @chalin: WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi all, I'm back.
Did you run this by @tigrannajaryan? As far as I recall, it was a deliberate decision originally to publish only the spec.
|
@svrnm @lmolkova - can we put a hold on this PR until we get feedback from @tigrannajaryan? |
|
Btw, if ever the decision is made to publish more, we don't need the changes introduced in this PR. The current docs folder organization is fine. |
|
So as it currently stands both the design goals & requirements docs are also published in the navigation panel of the website but rather than being integrated seamlessly into the site it is provided as a link to the github repo. Reason for introducing the specs folder is that provides a clear mapping of what docs gets mapped into the specs folder under docs on the website, allows for docs to be excluded from the website easily & it would enable other folders to be mounted at different locations. An example of what these other folders could be used for could be:
|
Which nav panel? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to #680 (comment) this change goes against the current practice of capturing only normative parts on the otel.io.
|
Oh, those are legacy entries (from the time that those pages were a part of the spec), which it might be time to remove. WDYT @lmolkova @tigrannajaryan et all? /cc @svrnm |
Come to think of it, I feel that the current situation with the legacy protocol section pages is fine as is. They redirect the reader to either the repo, or the OTLP specification, which is hosted on the OTel.io website. I'd vote to close this PR. Thoughts @lmolkova, @tigrannajaryan, @thompson-tomo, et all? |

These changes should enable the readme to be the entry point of the public docs and the other docs in the specs to also be published
Closes: #680