chore: improve dev setup for windows #1790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update update-ts-references to 2.0.0 to avoid that all tsconfig.json files get modified because of slashes (/ to \\) during npm install. Update .gitattributes to use LF also for json files as update-ts-references creates files using LF only even on windows.
Flarna
requested review from
OlivierAlbertini,
dyladan,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny and
vmarchaud
as code owners
vmarchaud
approved these changes
Jan 5, 2021
Codecov Report
@@ Coverage Diff @@
## master #1790 +/- ##
==========================================
+ Coverage 92.44% 92.49% +0.04%
==========================================
Files 173 173
Lines 6019 6019
Branches 1287 1287
==========================================
+ Hits 5564 5567 +3
+ Misses 455 452 -3
|
naseemkullah
approved these changes
Jan 5, 2021
dyladan
approved these changes
Jan 5, 2021
mwear
approved these changes
Jan 6, 2021
|
seems some tests are flaky as fails are unrelated to the changes. |
|
@Flarna yeah i'm currently looking into the flaky tests. Seem to have gotten much worse suddenly for some reason, but a flaky test isn't really acceptable anyways. |
|
@Flarna hopefully test flakiness should be solved |
obecny
approved these changes
Jan 11, 2021
dyladan
added a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Sep 9, 2022
Co-authored-by: Daniel Dyla <[email protected]>
dyladan
added a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Sep 9, 2022
Co-authored-by: Daniel Dyla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update update-ts-references to 2.0.0 to avoid that all tsconfig.json files get modified because of slashes (/ to \) during npm install.
Update .gitattributes to use LF also for json files as update-ts-references creates files using LF only even on windows.