Skip to content

Conversation

vasantteja
Copy link
Contributor

Resolves #6474

@vasantteja vasantteja requested a review from a team as a code owner August 26, 2025 01:18
Copy link

codecov bot commented Aug 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.01%. Comparing base (68fcd44) to head (e1fc21e).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #7616   +/-   ##
=========================================
  Coverage     90.01%   90.01%           
- Complexity     7090     7096    +6     
=========================================
  Files           803      803           
  Lines         21443    21461   +18     
  Branches       2092     2092           
=========================================
+ Hits          19301    19319   +18     
  Misses         1477     1477           
  Partials        665      665           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Co-authored-by: Hilmar Falkenberg <[email protected]>
Copy link

linux-foundation-easycla bot commented Sep 6, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@vasantteja
Copy link
Contributor Author

vasantteja commented Sep 6, 2025

CLA Not Signed

@hilmarf Can you please sign this so that I can include your suggestion?

Copy link
Contributor

@jkwatson jkwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me. Thanks!

@jkwatson
Copy link
Contributor

jkwatson commented Sep 7, 2025

@hilmarf Are you able to sign the CLA, so we can accept your contribution to this PR?

@zeitlinger
Copy link
Member

I'll also do a review.

@zeitlinger
Copy link
Member

Thanks a lot for the PR 😄

  • setMemoryMode and boolean useLowAllocation do the same thing - so we should stick to setMemoryMode
  • setWrapperJsonObject and useLowAllocation is unrelated - I don't understand why it was renamed
  • OtlpJsonLogging{Signal}Exporter is kind of deprecated
    • If you want to have more options, such as low allocation, you can use OtlpStdout{Signal}Exporter
    • e.g. OtlpStdoutLogRecordExporter.builder().setMemoryMode(MemoryMode.REUSABLE_DATA).build()

In total, I don't understand what is possible with this PR that was not possible before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OtlpJsonLogging{Signal}Exporters should have option to use low allocation OTLP marshalers
4 participants