-
Notifications
You must be signed in to change notification settings - Fork 904
Low allocation OTLP marshalers for OtlpJsonLogging{Signal}Exporters #7616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Low allocation OTLP marshalers for OtlpJsonLogging{Signal}Exporters #7616
Conversation
…/github.com/vasantteja/opentelemetry-java into low-allocation-marshalers-for-json-exporter
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7616 +/- ##
=========================================
Coverage 90.01% 90.01%
- Complexity 7090 7096 +6
=========================================
Files 803 803
Lines 21443 21461 +18
Branches 2092 2092
=========================================
+ Hits 19301 19319 +18
Misses 1477 1477
Partials 665 665 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
.../src/test/java/io/opentelemetry/exporter/logging/otlp/OtlpJsonLoggingMetricExporterTest.java
Outdated
Show resolved
Hide resolved
...p/src/main/java/io/opentelemetry/exporter/logging/otlp/OtlpJsonLoggingLogRecordExporter.java
Outdated
Show resolved
Hide resolved
...otlp/src/main/java/io/opentelemetry/exporter/logging/otlp/OtlpJsonLoggingMetricExporter.java
Outdated
Show resolved
Hide resolved
...g-otlp/src/main/java/io/opentelemetry/exporter/logging/otlp/OtlpJsonLoggingSpanExporter.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Hilmar Falkenberg <[email protected]>
@hilmarf Can you please sign this so that I can include your suggestion? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable to me. Thanks!
@hilmarf Are you able to sign the CLA, so we can accept your contribution to this PR? |
I'll also do a review. |
Thanks a lot for the PR 😄
In total, I don't understand what is possible with this PR that was not possible before. |
Resolves #6474