Skip to content

Move build to reusable workflow #5483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 4, 2022
Merged

Move build to reusable workflow #5483

merged 8 commits into from
Mar 4, 2022

Conversation

@trask
Copy link
Member

@trask trask commented Mar 2, 2022

No description provided.

@trask trask marked this pull request as ready for review March 2, 2022 21:00
@trask trask requested a review from a team March 2, 2022 21:00
@trask trask mentioned this pull request Mar 3, 2022
Merged
anuraaga
anuraaga reviewed Mar 3, 2022
View reviewed changes
.github/workflows/build.yml
- name: Start deadlock detector
run: .github/scripts/deadlock-detector.sh

- name: Build
Copy link
Contributor

@anuraaga anuraaga Mar 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a good time to change this to assemble instead of build? IIUC, we run tests on Java 11 twice, once as part of build and once as part of test

Copy link
Member Author

@trask trask Mar 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, I think I need to add check in there too...

Copy link
Contributor

@anuraaga anuraaga Mar 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check would run the tests - I had a proposal to change test to check in the test workflow to make defining additional tests easier, without our current boilerplate when defining special tests. Haven't done that yet but don't believe it affects the build workflow.

test
check -> test + spotless/checkstyle/etc
assemble -> jar, javadoc, sources
build -> assemble + check

Copy link
Contributor

@anuraaga anuraaga Mar 3, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh with my table I get it now, heh. Let's just leave it as build for now then, we'd probably switch to assemble here and check in the test workflow separately

@trask trask merged commit 8c5e2eb into open-telemetry:main Mar 4, 2022
@trask trask deleted the move-build-to-reusable-workflow branch March 4, 2022 17:54
RashmiRam pushed a commit to RashmiRam/opentelemetry-auto-instr-java that referenced this pull request May 23, 2022
@trask @RashmiRam
Move build to reusable workflow (open-telemetry#5483)
cf3f4f4 
* Move build to reusable workflow

* pass secrets where needed

* pass secrets where needed

* build -> assemble

* and check

* Revert "and check"

This reverts commit aa981d0.

* Revert "build -> assemble"

This reverts commit c00f6d1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@anuraaga anuraaga anuraaga approved these changes

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@trask @anuraaga @mateuszrzeszutek