add spring starter span logging #14594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
test native
|
🔧 The result from spotlessApply was committed to the PR branch. |
zeitlinger
force-pushed
the
spring-starter-logging-exporter
branch
from
8ccecdb to
9d31fc8
Compare
zeitlinger
commented
Oct 7, 2025
.../io/opentelemetry/instrumentation/logback/appender/v1_0/internal/LoggingEventMapperTest.java
Show resolved
Hide resolved
7 tasks
zeitlinger
changed the title
zeitlinger
changed the title
zeitlinger
force-pushed
the
spring-starter-logging-exporter
branch
from
5edd601 to
5a315c3
Compare
zeitlinger
moved this from Blocked
to Awaiting Review
in Declarative Configuration: Java
jaydeluca
approved these changes
Oct 8, 2025
laurit
reviewed
Oct 8, 2025
| */ | ||
| @Conditional(SdkEnabled.class) | ||
| // to match "otel.javaagent.debug" system property | ||
| @ConditionalOnProperty(name = "otel.spring-starter.debug", havingValue = "true") |
There was a problem hiding this comment.
There was a problem hiding this comment.
good point - also added the missing entry for #14449
trask
approved these changes
Oct 8, 2025
...ing/autoconfigure/internal/instrumentation/logging/LoggingExporterAutoConfigurationTest.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| @Test | ||
| void instrumentationDisabled() { |
There was a problem hiding this comment.
and one more test for debugDisable would be nice to be sure
Suggested change
| void instrumentationDisabled() { | |
| void debugUnset() { |
|
@trask please check again |
laurit
approved these changes
Oct 9, 2025
github-project-automation
bot
moved this from Awaiting Review
to Done
in Declarative Configuration: Java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #14087