Fix non-lowercase messaging headers #14479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
force-pushed
the
headers
branch
10 times, most recently
from
afebd62 to
6ebfe85
Compare
jaydeluca
approved these changes
Aug 22, 2025
laurit
approved these changes
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #14473
While HTTP headers are case insensitive by the HTTP specification, I don't believe messaging headers are.
I don't think removing the case normalization is breaking since it doesn't seem like non-lowercase messaging headers ever worked at all previously.
Probably we should also remove
-to_normalization (similar to what was done for HTTP headers), but that would be breaking so may want to wait for 3.0 for that.