-
Notifications
You must be signed in to change notification settings - Fork 1k
Fix rxjava context propagation for ObservableFromCallable #14393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepeshore
reviewed
Aug 11, 2025
...-2.0/library/src/main/java/io/opentelemetry/instrumentation/rxjava/v2_0/TracingAssembly.java
Outdated
Show resolved
Hide resolved
...ry/src/main/java/io/opentelemetry/instrumentation/rxjava/v2_0/TracingCallableObservable.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
Aug 11, 2025
...-2.0/library/src/main/java/io/opentelemetry/instrumentation/rxjava/v2_0/TracingAssembly.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
Aug 11, 2025
.../testing/src/main/java/io/opentelemetry/instrumentation/rxjava/v2_0/AbstractRxJava2Test.java
Show resolved
Hide resolved
laurit
reviewed
Aug 12, 2025
...-2.0/library/src/main/java/io/opentelemetry/instrumentation/rxjava/v2_0/TracingAssembly.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
Aug 12, 2025
...-2.0/library/src/main/java/io/opentelemetry/instrumentation/rxjava/v2_0/TracingAssembly.java
Outdated
Show resolved
Hide resolved
laurit
approved these changes
Aug 12, 2025
@jaydeluca can you check if the test latest deps failure is related?
|
@trask that testlatestDeps is happening on all PRs and I'm able to reproduce on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14382
When using
Observable.fromCallable()
with different schedulers (.subscribeOn()/.observeOn()), the context was not being propagated to the callable execution.ObservableFromCallable
is an internal class with a private callable, so I needed to do some reflection in the wrapper to make it work, but we now intercept and wrap the callable before it gets scheduled.