Use context instead of request attributes for servlet async instrumentation #13493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
commented
Mar 18, 2025
|
|
||
| private void attachAsyncListener(ServletRequestContext<REQUEST> requestContext) { | ||
| REQUEST request = requestContext.request(); | ||
| Context context = getServerContext(request); |
There was a problem hiding this comment.
Existing code was wrong here, we don't add context as request attribute on all servers so getServerContext returns null there.
|
@123liuziming could you verify whether this helps in your case |
It works, thanks! |
trask
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully resolves #13455
Keep async request handling state in context instead of using request attributes to avoid user application getting confused by these attributes.