Clear context propagation virtual field #12397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
approved these changes
Oct 4, 2024
| exceptions. | ||
| */ | ||
| propagatedContext.clear(); | ||
| virtualField.set(task, null); |
There was a problem hiding this comment.
maybe a comment here that this is only needed for cleaning up the fallback map?
or alternatively, do we want to just think of this as a "more correct" behavior?
There was a problem hiding this comment.
I added a comment. I think that with fallback map we need to do this, though ideally the fallback shouldn't be used at all which is what we really need to fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #12303
Set field to
nullafter restoring context or when task submission fails.