Make ApacheHttpClient5Request public #12394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanbisutti
approved these changes
Oct 3, 2024
jeanbisutti
reviewed
Oct 3, 2024
| import org.apache.hc.core5.http.ProtocolVersion; | ||
|
|
||
| final class ApacheHttpClient5Request { | ||
| public final class ApacheHttpClient5Request { |
There was a problem hiding this comment.
We should perhaps add Javadoc?
jaydeluca
approved these changes
Oct 5, 2024
steverao
reviewed
Oct 7, 2024
| } | ||
|
|
||
| @Nullable | ||
| public InetSocketAddress getServerSocketAddress() { |
There was a problem hiding this comment.
It seems many methods in this class was copied from other version modules, delete them together? such as
There was a problem hiding this comment.
this method is used in 4.3 instrumentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #12393
Also removes unused code.