Add declarative config support for resource providers #12144
Conversation
github-actions
bot
added
the
test native
| * href="https://github.com/open-telemetry/semantic-conventions/blob/main/docs/resource/host.md#non-privileged-machine-id-lookup">the | ||
| * semantic conventions</a> | ||
| */ | ||
| public final class HostIdResourceProvider implements ConditionalResourceProvider { |
There was a problem hiding this comment.
This class didn't follow the pattern of the others. Instead of having a Resource HostIdResource.get() method for calling directly by users, and a separate HostIdResourceProvider for integration with autoconfigure, it only had autoconfigure support.
I've refactored it to follow the pattern used elsewhere, which makes it easy to add a ComponentProvider implementation in HostIdResourceComponentProvider.
There was a problem hiding this comment.
I noticed that there is no documentation for the JarServiceNameDetector or ManifestResourceProvider, and that these can't be used outside of autoconfigure.
@zeitlinger, since you wrote ManifestResourceProvider, were these omissions intentional?
There was a problem hiding this comment.
no, I didn't think about this use case
| * href="https://github.com/open-telemetry/semantic-conventions/blob/main/docs/resource/host.md#non-privileged-machine-id-lookup">the | ||
| * semantic conventions</a> | ||
| */ | ||
| public final class HostIdResource { |
There was a problem hiding this comment.
Nothing new in this class - just breaking out HostIdResourceProvider into two classes.
| // this line is managed by .github/scripts/update-sdk-version.sh | ||
| val otelSdkVersion = "1.41.0" | ||
| // TODO: revert before merging | ||
| val otelSdkVersion = "1.42.0-SNAPSHOT" |
There was a problem hiding this comment.
Will resolve after #12186 is merged
.../io/opentelemetry/instrumentation/resources/internal/ContainerResourceComponentProvider.java
Outdated
Show resolved
Hide resolved
4 participants
Implement the declarative configuration
ComponentProvider<Resource>SPI now that support has been added for resources in open-telemetry/opentelemetry-java#6625.