Restrict operator version to 63 chars #1778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samiura
changed the title
samiura
changed the title
TylerHelmuth
approved these changes
Aug 4, 2025
jaronoff97
approved these changes
Aug 4, 2025
nlamirault
added a commit
to nlamirault/opentelemetry-helm-charts
that referenced
this pull request
Aug 7, 2025
* main: (23 commits) fix: image tags longer than 63 chars getting truncated (open-telemetry#1790) Add revisionHistoryLimit to statefulset and daemonset (open-telemetry#1780) Bump docker/login-action from 3.4.0 to 3.5.0 (open-telemetry#1787) Bump github/codeql-action from 3.29.3 to 3.29.5 (open-telemetry#1786) Restrict operator version to 63 chars (open-telemetry#1778) [opentelemetry-kube-stack]: bump operatot depdendcy to 0.129.1 (open-telemetry#1776) [target-allocator] Add missing Kubernetes recommended labels (open-telemetry#1745) [opentelemetry-collector]: bump collector version to 0.130.0 (open-telemetry#1775) fix: use part-of kubernetes label instead of instance in demo chart (open-telemetry#1752) [opentelemetry-operator] allow for overriding namespace in values file (open-telemetry#1758) Bump github/codeql-action from 3.29.2 to 3.29.3 (open-telemetry#1769) [opentelemetry-kube-stack]: Merge both collectors in a single one with leader election (open-telemetry#1735) [opentelemtry-operator]: bump to 0.129.1 (open-telemetry#1764) [opentelemtry-collector]: bump to version 0.130.0 (open-telemetry#1763) [opentelemetry-collector]: bump to 0.129.0 (open-telemetry#1762) [operator] Resources for testFramework containers (open-telemetry#1746) fix(opentelemetry-collector): always sort prometheus resource attrs (open-telemetry#1748) Add minimum token permissions for all github workflow files (open-telemetry#1741) [kube-stack] bump operator to 0.91.0 and add target allocator crd (open-telemetry#1761) [collector] - Update Prometheus alerts (open-telemetry#1736) ... Signed-off-by: Nicolas Lamirault <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are multiple resources deployed by the otel operator that have the following required label
app.kubernetes.io/version . The label value must be below 63 char, defined here.
The image tag is being set in the opentelemetry operator here - https://github.com/open-telemetry/opentelemetry-helm-charts/blob/opentelemetry-ope[…]tor-0.76.0/charts/opentelemetry-operator/templates/_helpers.tpl
and used in the label here - https://github.com/open-telemetry/opentelemetry-helm-charts/blob/opentelemetry-ope[…]tor-0.76.0/charts/opentelemetry-operator/templates/_helpers.tpl
Previously it was set to appVersion and did not cause any problems. But if image SHA256 digest is used, the image tag can easily be over 63 char and hence deployment is not possible for people using this as a subchart.
Related issue: #1637