-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Run compatibility tests on arm64 with actuated #4994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can you add a "playbook" for troubleshooting this? It would be ideal if have documentation about how this is run and how to handle failures. |
The usage is very basic (the So I wonder if it's worth having specific documentation in this repository. Maybe that should rather be in the community repository (I'm happy to open it there). cc @atoulme |
Probably a great idea to have a small doc on the community repository and link it from your build instructions. We have been learning a fair amount since the start of the engagement. Other teams also are on different adoption curves on this so they'd all benefit. |
Could we have a doc (maybe on https://github.com/open-telemetry/community) to present a best practice for using actuated service on github action? By making it a standard for supporting ARM, all teams can use the same snippet code and have a uniform playbook to handle exceptions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use tagged version otherwise the CI may become unstable after a new major release of a GitHub Action.
I have started adding documentation on the community repository: open-telemetry/community#1983 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also update https://github.com/open-telemetry/opentelemetry-go?tab=readme-ov-file#compatibility?
Currently, this project supports the following environments.
See the PR description:
If you feel there's no risk at all, I'm happy to make it public now though. |
I feel there is almost no risk. I think there is a higher risk that we will forget to update the matrix 😉 You can leave the PR as it is if you do not agree. The PR is good enough for me. |
I have updated the compatibility matrix. Actuated doesn't seem to communicate on which linux distribution they use in their runners, so I'm happy to change it to |
Then I would change it to @alexellis any suggestions? |
We use Ubuntu 22.04 at present. You can simply create a job at any time and run |
@dmathieu I think it is worth adding a mention in the changelog. WDYT? EDIT: E.g. something like "Add ARM64 platform to the compatibility testing suite". I am waiting for your feedback before clicking the "merge" button. |
I have added a changelog entry. However, I also think we should wait for open-telemetry/community#1983 to be merged, so we can link to that doc. |
Co-authored-by: Robert Pająk <[email protected]>
Co-authored-by: Robert Pająk <[email protected]>
Co-authored-by: Robert Pająk <[email protected]>
Co-authored-by: Robert Pająk <[email protected]>
With the community PR being merged, this PR is ready to go! |
Thanks @dmathieu ! |
Following open-telemetry/community#1954, this is using the actuated self-hosted runners provided by the CNCF to run the compatibility tests on the ARM architecture.
This doesn't update the compatibility matrix yet, the intent is to have the new tests running for a couple weeks to ensure their stability before we commit to a public change.