Skip to content

Conversation

@MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Mar 3, 2021

Resolves #1637

API prior to change:

20210303_131213

Post change:

20210303_131250

@MrAlias MrAlias added the pkg:SDK Related to an SDK package label Mar 3, 2021
@MrAlias MrAlias requested a review from Aneurysm9 as a code owner March 3, 2021 21:13
@MrAlias MrAlias self-assigned this Mar 3, 2021
@codecov
Copy link

codecov bot commented Mar 3, 2021

Codecov Report

Merging #1638 (4d0c72b) into main (992837f) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #1638   +/-   ##
=====================================
  Coverage   77.3%   77.3%           
=====================================
  Files        128     128           
  Lines       6671    6669    -2     
=====================================
  Hits        5157    5157           
+ Misses      1267    1265    -2     
  Partials     247     247           
Impacted Files Coverage Δ
sdk/trace/batch_span_processor.go 78.8% <100.0%> (ø)
sdk/trace/simple_span_processor.go 75.0% <100.0%> (ø)
exporters/trace/jaeger/env.go 100.0% <0.0%> (ø)
exporters/otlp/otlpgrpc/connection.go 88.7% <0.0%> (+1.8%) ⬆️

@MrAlias MrAlias added this to the RC1 milestone Mar 4, 2021
@MrAlias MrAlias merged commit 62e2a0f into open-telemetry:main Mar 5, 2021
@MrAlias MrAlias deleted the ssp-bsp-unexport branch March 5, 2021 16:08
@MrAlias MrAlias mentioned this pull request Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg:SDK Related to an SDK package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unexport the SimpleSpanProcessor and BatchSpanProcessor structs

3 participants