Update net/http instrumentation to comply with semantic conventions
#790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RonFed
reviewed
Apr 19, 2024
MrAlias
reviewed
Apr 24, 2024
Contributor
MrAlias
left a comment
MrAlias
left a comment
There was a problem hiding this comment.
Overall looks good. Just the full URL and semconv versioning look like the only items that need to be addressed.
RonFed
reviewed
May 3, 2024
RonFed
reviewed
May 5, 2024
internal/pkg/instrumentation/bpf/net/http/client/bpf/probe.bpf.c
Outdated
Show resolved
Hide resolved
damemi
force-pushed
the
issue-169
branch
3 times, most recently
from
3352728 to
3401852
Compare
Member
Author
|
I think test failure is unrelated and fixed by #820 |
grcevski
reviewed
May 7, 2024
damemi
force-pushed
the
issue-169
branch
4 times, most recently
from
7a180bd to
68e6874
Compare
MrAlias
approved these changes
May 8, 2024
Contributor
RonFed
approved these changes
May 8, 2024
Contributor
RonFed
left a comment
RonFed
left a comment
There was a problem hiding this comment.
Added a comment about the Makefile change, other than that looks great.
Member
Author
|
ready to merge @MrAlias |
Merged
This was referenced Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #169
This does the following:
span.Statusfor 4xx and 5xx codes in Client, and just 5xx codes in Serverprotocol.namewhen the protocol is notHTTPfor both Client and Serverurl.fullattribute from the protocol+host+path for Clientopentelemetry/controller_test.goto check that the output gets exported as expectedurl.fullfieldThis PR adds changes to the net/http eBPF instrumentation to copy the full set of fields from the
*net/url.URLobject in the Request to reconstruct aurl.fullattribute. It copies each field individually because the object is a pointer to an address in user space which would not be accessible by the auto-instrumentation agent. The agent reconstructs the GoURLobject so that it can callurl.String(), which uses logic and control flags in the original object to build the string representation (rather than building the string manually in the eBPF program).