Skip to content

config: NewSDK can return valid TracerProvider #4741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jan 16, 2024
Merged

config: NewSDK can return valid TracerProvider #4741

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
30a9da2
implement TracerProvider functionality
Dec 21, 2023
e6e0bd6
add changelog
Dec 21, 2023
197f68f
tidy
Dec 21, 2023
4f2b53e
Update config/config_test.go
codeboten Dec 30, 2023
ef3a540
Update CHANGELOG.md
codeboten Dec 30, 2023
ef88f92
rename func to remove init prefix
Jan 10, 2024
f8c02e9
clean up slice definition
Jan 10, 2024
baed360
Update config/trace_test.go
codeboten Jan 10, 2024
dce813c
Merge branch 'main' into codeboten/add-tracer-provider-sdk
codeboten Jan 10, 2024
fc687de
add consts for compression options
Jan 10, 2024
491688e
fix typo
Jan 10, 2024
e17f314
fix test
Jan 10, 2024
7ceb8c4
remove unnecessary var
Jan 10, 2024
0d278d2
add check for multiple types being configured
Jan 10, 2024
e7a8193
combine errors instead of immediately returning
Jan 10, 2024
5b14adb
remove normalizeEndpoint
Jan 11, 2024
17cfab9
add comment re no scheme use-case
Jan 11, 2024
f09ea01
Update config/trace.go
pellared Jan 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions config/trace.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,11 @@ func otlpGRPCSpanExporter(ctx context.Context, otlpConfig *OTLP) (sdktrace.SpanE
if err != nil {
return nil, err
}
// ParseRequestURI leaves the Host field empty when no
// scheme is specified (i.e. localhost:4317). This check is
// here to support the case where a user may not specify a
// scheme. The code does its best effort here by using
// otlpConfig.Endpoint as-is in that case
if u.Host != "" {
opts = append(opts, otlptracegrpc.WithEndpoint(u.Host))
} else {
Expand Down