-
Notifications
You must be signed in to change notification settings - Fork 681
otelgrpc: Fix data race in stats handlers when processing messages received and sent metrics #4577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
1c4d2ec
fix data race from stats_handler.go (#1)
naphatkrit 0321279
add test for stats_handler (#2)
naphatkrit ab2264b
Merge branch 'open-telemetry:main' into main
naphatkrit fc217ae
do full test
naphatkrit e70689c
simulate data race in test for real
naphatkrit 150d4f1
Update grpc_stats_handler_test.go
naphatkrit 40a6ab7
fix fmt import
naphatkrit 1e42c20
update changelog
naphatkrit d590a3b
ran make
naphatkrit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 changes: 40 additions & 0 deletions
40
instrumentation/google.golang.org/grpc/otelgrpc/stats_handler_test.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
package otelgrpc | ||
|
||
import ( | ||
"context" | ||
"sync" | ||
"testing" | ||
|
||
"google.golang.org/grpc/stats" | ||
) | ||
|
||
func TestHandleRPC(t *testing.T) { | ||
const iteration = 100 | ||
wg := &sync.WaitGroup{} | ||
ctx := context.Background() | ||
h := NewClientHandler() | ||
ctx = h.TagRPC(ctx, &stats.RPCTagInfo{ | ||
FullMethodName: "test/method", | ||
}) | ||
for i := 0; i < iteration; i++ { | ||
wg.Add(1) | ||
go func() { | ||
defer wg.Done() | ||
h.HandleRPC(ctx, &stats.Begin{}) | ||
wg.Add(3) | ||
go func() { | ||
defer wg.Done() | ||
h.HandleRPC(ctx, &stats.InPayload{}) | ||
}() | ||
go func() { | ||
defer wg.Done() | ||
h.HandleRPC(ctx, &stats.OutPayload{}) | ||
}() | ||
go func() { | ||
defer wg.Done() | ||
h.HandleRPC(ctx, &stats.End{}) | ||
}() | ||
}() | ||
} | ||
wg.Wait() | ||
} | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.