Skip to content

Conversation

arenavalerio
Copy link
Contributor

@arenavalerio arenavalerio commented Jun 4, 2025

Fixes #6042
Adding an implementation of AddLink method in TelemetrySpan class

Changes

  • Adding AddLink method to TelemetrySpan class
  • Adding relevant unit tests
  • Adding relevant lines for public API changes

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

Copy link

linux-foundation-easycla bot commented Jun 4, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@github-actions github-actions bot added the pkg:OpenTelemetry.Api Issues related to OpenTelemetry.Api NuGet package label Jun 4, 2025
@arenavalerio arenavalerio marked this pull request as ready for review June 5, 2025 18:52
@arenavalerio arenavalerio requested a review from a team as a code owner June 5, 2025 18:52
Copy link

codecov bot commented Jun 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.78%. Comparing base (1544659) to head (3fedb61).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6305      +/-   ##
==========================================
+ Coverage   86.75%   86.78%   +0.03%     
==========================================
  Files         258      258              
  Lines       11872    11879       +7     
==========================================
+ Hits        10299    10309      +10     
+ Misses       1573     1570       -3     
Flag Coverage Δ
unittests-Project-Experimental 86.57% <100.00%> (+0.16%) ⬆️
unittests-Project-Stable 86.39% <100.00%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/OpenTelemetry.Api/Trace/TelemetrySpan.cs 89.47% <100.00%> (+1.06%) ⬆️

... and 2 files with indirect coverage changes

Copy link
Member

@alanwest alanwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @arenavalerio!

This was referenced Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg:OpenTelemetry.Api Issues related to OpenTelemetry.Api NuGet package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feature request] Add support to 'add links' to TelemetrySpan as it was added to Activity in .net9

2 participants