Skip to content

Conversation

@rajkumar-rangaraj
Copy link
Member

Fixes #4831
Design discussion issue #

This PR addresses the stabilization of exception attributes in the OpenTelemetry Semantic Conventions. With exception.type, exception.message, and exception.stacktrace now considered stable, the need for the OTEL_DOTNET_EXPERIMENTAL_OTLP_EMIT_EXCEPTION_LOG_ATTRIBUTES environment variable has been eliminated.

Changes

Please provide a brief description of the changes here.

  • Removed the OTEL_DOTNET_EXPERIMENTAL_OTLP_EMIT_EXCEPTION_LOG_ATTRIBUTES environment variable.
  • Ensured that exception.type, exception.message, and exception.stacktrace are automatically included in exports

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • [ ] Changes in public API reviewed (if applicable)

…ag as exception attributes are now standard.
@rajkumar-rangaraj rajkumar-rangaraj requested a review from a team January 25, 2024 20:02
@codecov
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6250307) 83.38% compared to head (72d49da) 83.12%.
Report is 31 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5258      +/-   ##
==========================================
- Coverage   83.38%   83.12%   -0.26%     
==========================================
  Files         297      271      -26     
  Lines       12531    11967     -564     
==========================================
- Hits        10449     9948     -501     
+ Misses       2082     2019      -63     
Flag Coverage Δ
unittests ?
unittests-Solution-Experimental 83.11% <100.00%> (?)
unittests-Solution-Stable 82.85% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...etryProtocol/Implementation/ExperimentalOptions.cs 100.00% <ø> (ø)
...rotocol/Implementation/OtlpLogRecordTransformer.cs 93.45% <100.00%> (ø)
...tation.AspNetCore/Implementation/HttpInListener.cs 89.72% <100.00%> (+0.14%) ⬆️
...AspNetCore/Implementation/HttpInMetricsListener.cs 89.47% <ø> (ø)
...plementation/HttpWebRequestActivitySource.netfx.cs 80.77% <100.00%> (ø)
...emetry/Metrics/Exemplar/SimpleExemplarReservoir.cs 80.43% <100.00%> (ø)

... and 34 files with indirect coverage changes

Copy link
Member

@Kielek Kielek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@CodeBlanch CodeBlanch added the pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package label Jan 26, 2024
@CodeBlanch CodeBlanch changed the title Remove Experimental Flag from OTLP Exporter for Standardized Exception Attributes [otlp] Remove Experimental Flag and emit stable Exception attributes by default Jan 26, 2024
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sent a nit on CHANGELOG but LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Export LogRecord.Exception data when using otlp exporter

6 participants