Added wildcard support for meter sources. #2459

Yun-Ting · 2021-10-06T22:02:18Z

Changes

src/OpenTelemetry/Metrics/MeterProviderSdk.cs

codecov · 2021-10-06T22:09:36Z

Codecov Report

Merging #2459 (dc84c7d) into main (db8f0e7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2459   +/-   ##
=======================================
  Coverage   79.83%   79.84%           
=======================================
  Files         254      254           
  Lines        8385     8394    +9     
=======================================
+ Hits         6694     6702    +8     
- Misses       1691     1692    +1

Impacted Files	Coverage Δ
src/OpenTelemetry/Metrics/MeterProviderSdk.cs	`92.08% <100.00%> (+0.30%)`	⬆️
...ZPages/Implementation/ZPagesExporterEventSource.cs	`56.25% <0.00%> (-6.25%)`	⬇️

src/OpenTelemetry/Metrics/MeterProviderSdk.cs

…un-Ting/opentelemetry-dotnet into Yun-Ting/Metricsource-wildcard

src/OpenTelemetry/Metrics/MeterProviderSdk.cs

test/OpenTelemetry.Tests/Metrics/MetricAPITest.cs

src/OpenTelemetry/Metrics/MeterProviderSdk.cs

test/OpenTelemetry.Tests/Metrics/MetricAPITest.cs

Co-authored-by: Cijo Thomas <[email protected]>

test/OpenTelemetry.Tests/Metrics/MetricAPITest.cs

src/OpenTelemetry/Metrics/MeterProviderSdk.cs

test/OpenTelemetry.Tests/Metrics/MetricAPITest.cs

src/OpenTelemetry/Metrics/MeterProviderSdk.cs

test/OpenTelemetry.Tests/Metrics/MetricAPITest.cs

src/OpenTelemetry/Metrics/MeterProviderSdk.cs

reyang

LGTM.

src/OpenTelemetry/Metrics/MeterProviderSdk.cs

test/OpenTelemetry.Tests/Metrics/MetricAPITest.cs

cijothomas

LGTM.
some minor comments are pending - can be follow up PR

Yun-Ting added 2 commits October 6, 2021 14:57

main logic

eb24783

tests to be finished

a3392a2

Yun-Ting changed the title ~~Yun ting/metricsource wildcard~~ Added wildcard support for meter sources. Oct 6, 2021

cijothomas reviewed Oct 6, 2021

View reviewed changes

src/OpenTelemetry/Metrics/MeterProviderSdk.cs Outdated Show resolved Hide resolved

Yun-Ting commented Oct 6, 2021

View reviewed changes

src/OpenTelemetry/Metrics/MeterProviderSdk.cs Outdated Show resolved Hide resolved

comment and test

3d9396a

Yun-Ting marked this pull request as ready for review October 7, 2021 07:24

Yun-Ting requested a review from a team October 7, 2021 07:24

Merge branch 'main' into Yun-Ting/Metricsource-wildcard

f8c5a2d

cijothomas reviewed Oct 7, 2021

View reviewed changes

src/OpenTelemetry/Metrics/MeterProviderSdk.cs Outdated Show resolved Hide resolved

Yun-Ting added 3 commits October 7, 2021 09:51

fix logic

690970d

Merge branch 'Yun-Ting/Metricsource-wildcard' of https://github.com/Y…

ea45c8d

…un-Ting/opentelemetry-dotnet into Yun-Ting/Metricsource-wildcard

fix and clean

af79097

utpilla reviewed Oct 7, 2021

View reviewed changes

src/OpenTelemetry/Metrics/MeterProviderSdk.cs Outdated Show resolved Hide resolved

utpilla reviewed Oct 7, 2021

View reviewed changes

test/OpenTelemetry.Tests/Metrics/MetricAPITest.cs Outdated Show resolved Hide resolved

Yun-Ting added 2 commits October 7, 2021 15:24

comments

490c0ae

Merge branch 'main' into Yun-Ting/Metricsource-wildcard

1079fe5

cijothomas reviewed Oct 7, 2021

View reviewed changes

src/OpenTelemetry/Metrics/MeterProviderSdk.cs Outdated Show resolved Hide resolved

cijothomas reviewed Oct 7, 2021

View reviewed changes

src/OpenTelemetry/Metrics/MeterProviderSdk.cs Outdated Show resolved Hide resolved

cijothomas reviewed Oct 7, 2021

View reviewed changes

test/OpenTelemetry.Tests/Metrics/MetricAPITest.cs Show resolved Hide resolved

cijothomas reviewed Oct 7, 2021

View reviewed changes

test/OpenTelemetry.Tests/Metrics/MetricAPITest.cs Outdated Show resolved Hide resolved

cijothomas reviewed Oct 7, 2021

View reviewed changes

test/OpenTelemetry.Tests/Metrics/MetricAPITest.cs Outdated Show resolved Hide resolved

utpilla reviewed Oct 7, 2021

View reviewed changes

test/OpenTelemetry.Tests/Metrics/MetricAPITest.cs Outdated Show resolved Hide resolved

utpilla reviewed Oct 7, 2021

View reviewed changes

test/OpenTelemetry.Tests/Metrics/MetricAPITest.cs Outdated Show resolved Hide resolved

Yun-Ting and others added 5 commits October 7, 2021 16:17

ver1

9cf83e1

Update test/OpenTelemetry.Tests/Metrics/MetricAPITest.cs

81be58a

Co-authored-by: Cijo Thomas <[email protected]>

comments

18e1b3c

merge from remote

3797f04

supress test code warning

98d87f6

utpilla reviewed Oct 8, 2021

View reviewed changes

test/OpenTelemetry.Tests/Metrics/MetricAPITest.cs Outdated Show resolved Hide resolved

reyang reviewed Oct 8, 2021

View reviewed changes

src/OpenTelemetry/Metrics/MeterProviderSdk.cs Outdated Show resolved Hide resolved

reyang reviewed Oct 8, 2021

View reviewed changes

src/OpenTelemetry/Metrics/MeterProviderSdk.cs Outdated Show resolved Hide resolved

Yun-Ting added 3 commits October 8, 2021 11:17

refactor tests and resolve comments

2a71abc

readability

c0954e5

added test comments

e045d12

utpilla reviewed Oct 8, 2021

View reviewed changes

test/OpenTelemetry.Tests/Metrics/MetricAPITest.cs Show resolved Hide resolved

utpilla reviewed Oct 8, 2021

View reviewed changes

test/OpenTelemetry.Tests/Metrics/MetricAPITest.cs Outdated Show resolved Hide resolved

cijothomas reviewed Oct 8, 2021

View reviewed changes

src/OpenTelemetry/Metrics/MeterProviderSdk.cs Outdated Show resolved Hide resolved

cijothomas reviewed Oct 8, 2021

View reviewed changes

test/OpenTelemetry.Tests/Metrics/MetricAPITest.cs Show resolved Hide resolved

cijothomas reviewed Oct 8, 2021

View reviewed changes

test/OpenTelemetry.Tests/Metrics/MetricAPITest.cs Outdated Show resolved Hide resolved

utpilla reviewed Oct 8, 2021

View reviewed changes

src/OpenTelemetry/Metrics/MeterProviderSdk.cs Outdated Show resolved Hide resolved

resolved comments; added null check for shouldListento

f886d9a

utpilla reviewed Oct 8, 2021

View reviewed changes

src/OpenTelemetry/Metrics/MeterProviderSdk.cs Outdated Show resolved Hide resolved

reyang approved these changes Oct 8, 2021

View reviewed changes

Yun-Ting added 3 commits October 8, 2021 15:37

comment

bd2aedb

merge from master

cc568e1

resolve conflicts

dc84c7d

utpilla reviewed Oct 9, 2021

View reviewed changes

src/OpenTelemetry/Metrics/MeterProviderSdk.cs Show resolved Hide resolved

utpilla approved these changes Oct 9, 2021

View reviewed changes

cijothomas reviewed Oct 9, 2021

View reviewed changes

test/OpenTelemetry.Tests/Metrics/MetricAPITest.cs Show resolved Hide resolved

cijothomas approved these changes Oct 9, 2021

View reviewed changes

cijothomas merged commit c79ad98 into open-telemetry:main Oct 9, 2021

joaopgrassi mentioned this pull request Oct 11, 2021

Add validation to instrument and view name #2470

Merged

2 tasks

Yun-Ting mentioned this pull request Oct 11, 2021

Changes around MeterProviderSdk, resolving pending comments. #2474

Merged

Yun-Ting deleted the Yun-Ting/Metricsource-wildcard branch October 13, 2021 21:21

reyang mentioned this pull request Oct 27, 2021

MeterProviderBuilder AddMeter is not supporting wildcard subscription model #2529

Closed

Uh oh!

Added wildcard support for meter sources. #2459

Added wildcard support for meter sources. #2459

Uh oh!

Conversation

Yun-Ting commented Oct 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

Uh oh!

codecov bot commented Oct 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

reyang left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cijothomas left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Yun-Ting commented Oct 6, 2021 •

edited

Loading

codecov bot commented Oct 6, 2021 •

edited

Loading