[bug] OTEL_TRACES_SAMPLER_ARG not parsed invariantly

[dk-teknologisk-lvq]

Package

OpenTelemetry

Package Version

Package Name	Version
OpenTelemetry	1.12.0

Runtime Version

net9.0

Description

Using the OTEL_TRACES_SAMPLER_ARG variable with the OTEL_TRACES_SAMPLER variable set to traceidratio the value will not be parsed invariantly thus being dependent on the culture of the local machine. This leads to issues when your local culture expects , as decimal delimiter instead of ., which means 0.25 will be parsed as 25 which is an invalid value.

This can be rectified at this line:

opentelemetry-dotnet/src/OpenTelemetry/Trace/TracerProviderSdk.cs

Line 461 in 7a4643a

double.TryParse(configValue, out var traceIdRatio))

Steps to Reproduce

See the general description.

Expected Result

See the general description.

Actual Result

See the general description.

Additional Context

No response

[Kielek]

Fix in progress #6444

[dk-teknologisk-lvq]

Awesome work! I'll look forward to a fix 🥳

[dk-teknologisk-lvq]

@Kielek I'm not familiar with the release procedures for this project, but wouldn't it be better to release this bugfix as a patch version? I'm of course coming from a totally selfish place, where I need the fix now, but still, it's such a minor fix that I find it silly to wait until at least November before releasing a long side .NET 10 support. Thoughts? 🙂

[Kielek]

I doubt that we will kick the release only for this small bugfix. Any option to change your system locales to .-separator centric?

@rajkumar-rangaraj, @alanwest, WDYT?

[dk-teknologisk-lvq]

That's understandable - I've changed my local config to just not sample for now. Our production systems are running with a locale using . as delimiter. Thanks for the quick responses, much appriciated!