-
Notifications
You must be signed in to change notification settings - Fork 354
[Exporter.Geneva] Fix AFDCorrelationId retrieval exception handling in Geneva Exporter #2708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Exporter.Geneva] Fix AFDCorrelationId retrieval exception handling in Geneva Exporter #2708
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2708 +/- ##
===========================================
- Coverage 73.91% 52.84% -21.08%
===========================================
Files 267 55 -212
Lines 9615 5079 -4536
===========================================
- Hits 7107 2684 -4423
+ Misses 2508 2395 -113
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
Overall LGTM |
src/OpenTelemetry.Exporter.Geneva/Internal/AFDCorrelationIdLogProcessor.cs
Show resolved
Hide resolved
src/OpenTelemetry.Exporter.Geneva/Internal/AFDCorrelationIdLogProcessor.cs
Show resolved
Hide resolved
test/OpenTelemetry.Exporter.Geneva.Tests/GenevaLogExporterAFDCorrelationTests.cs
Show resolved
Hide resolved
| // Check that no exceptions were thrown | ||
| // If our implementation is correct, logs from threads without correlation ID | ||
| // should have been processed without exceptions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this meant to be a TODO?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a statement indicating that no exceptions were thrown. Since the existing implementation threw an exception, I had to add it, instead of making test complex.
Fixes #
Design discussion issue #
The
AFDCorrelationIdLogProcessorwas throwing unhandled exceptions when attempting to retrieve theAFDCorrelationIdfromRuntimeContextif the value had not been previously set by customers. This caused processing failures in the telemetry pipeline.Solution.
Changes
Please provide a brief description of the changes here.
GenevaAfdCorrelationIdStateTrackerto remember when access failures occurMerge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes