Skip to content

Conversation

@Kielek
Copy link
Member

@Kielek Kielek commented Jan 23, 2025

Fixes GHSA-4cv2-4hjh-77rx
It was transitive dependency to WireMock.NET < 1.7.0

Changes

[Sampler.AWS] Bump WireMock.Net to 1.7.0
Bump xunit to 2.9.3

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • [ ] Appropriate CHANGELOG.md files updated for non-trivial changes
  • [ ] Changes in public API reviewed (if applicable)

@Kielek Kielek requested a review from a team as a code owner January 23, 2025 05:52
@github-actions github-actions bot requested review from ppittle and srprash January 23, 2025 05:52
@github-actions github-actions bot added infra Infra work - CI/CD, code coverage, linters comp:sampler.aws Things related to OpenTelemetry.Samplers.AWS labels Jan 23, 2025
@Kielek Kielek requested review from CodeBlanch and alanwest January 23, 2025 06:07
@Kielek Kielek changed the title [Sampler.AWS] Bump WireMock.Net to 1.7.0 [Sampler.AWS] Tests - Bump WireMock.Net to 1.7.0 Jan 23, 2025
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Kielek!

@CodeBlanch CodeBlanch merged commit 4f2e9d0 into open-telemetry:main Jan 23, 2025
213 of 214 checks passed
@codecov
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (71655ce) to head (34a6ffc).
Report is 686 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #2478       +/-   ##
==========================================
- Coverage   73.91%       0   -73.92%     
==========================================
  Files         267       0      -267     
  Lines        9615       0     -9615     
==========================================
- Hits         7107       0     -7107     
+ Misses       2508       0     -2508     

see 263 files with indirect coverage changes

@Kielek Kielek deleted the wiremock branch January 23, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:sampler.aws Things related to OpenTelemetry.Samplers.AWS infra Infra work - CI/CD, code coverage, linters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants