Skip to content

Conversation

dbarker
Copy link
Member

@dbarker dbarker commented Jul 8, 2025

Fixes # (issue)

Changes

  • Switch opentelemetry-proto to use the FetchContent module instead of the ExternalProject module.
  • Set and log the opentelemetry-proto_VERSION and opentelemetry-proto_PROVIDER variables.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

Copy link

netlify bot commented Jul 8, 2025

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit 4c9676c
🔍 Latest deploy log https://app.netlify.com/projects/opentelemetry-cpp-api-docs/deploys/686e9545b828900008767cda

Copy link

codecov bot commented Jul 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.96%. Comparing base (1ad6674) to head (4c9676c).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3524   +/-   ##
=======================================
  Coverage   89.96%   89.96%           
=======================================
  Files         219      219           
  Lines        7051     7051           
=======================================
  Hits         6343     6343           
  Misses        708      708           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dbarker dbarker marked this pull request as ready for review July 8, 2025 21:23
@dbarker dbarker requested a review from a team as a code owner July 8, 2025 21:23
Copy link
Member

@owent owent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@marcalff marcalff merged commit 6c4d45c into open-telemetry:main Jul 9, 2025
70 checks passed
malkia added a commit to malkia/opentelemetry-cpp that referenced this pull request Jul 10, 2025
[CMAKE] Switch opentelemetry-proto to use FetchContent (open-telemetry#3524)
@dbarker dbarker deleted the cmake_switch_opentelemetry_proto_to_fetch_content branch July 10, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants