[CMAKE] Add thirdparty install cmake project and install bash script #3486

dbarker · 2025-06-17T19:54:44Z

The third-party package installs for ci testing have a few challenges/limitations:

The packages are installed by four bash scripts and creating consistent builds (common cxx standard, cmake args, ...) can be challenging.
Versions are set by script defaults or environment variables in ci yml and don't use the git tags from third_party_release.
Creating compatible installs of abseil, protobuf, and grpc can be challenging. Script input args need to be correct to avoid creating duplicate/conflicting builds of abseil and protobuf with grpc.

The goal of this PR is to make managing/maintaining third party dependencies for CI testing easier.

Changes

creates a opentelemetry-cpp-thirdparty-install CMake project and adds tags files for minimum supported, "stable", and latest versions.
creates a install_thirdparty.sh script for Linux
use the third-party install project/script in the devcontainer and ci jobs that test otlp components.

For significant contributions please make sure you have completed the following items:

CHANGELOG.md updated for non-trivial changes
Unit tests have been added
Changes in public API reviewed

netlify · 2025-06-17T19:57:32Z

✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name	Link
🔨 Latest commit	`ad724fe`
🔍 Latest deploy log	https://app.netlify.com/projects/opentelemetry-cpp-api-docs/deploys/685c27f62304b20008cc9d89

codecov · 2025-06-17T20:12:50Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.93%. Comparing base (016155f) to head (ad724fe).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3486   +/-   ##
=======================================
  Coverage   89.93%   89.93%           
=======================================
  Files         219      219           
  Lines        7039     7039           
=======================================
  Hits         6330     6330           
  Misses        709      709

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

… script to replace the setup_grpc, install_abseil, setup_googletest, and install_protobuf scripts in ci jobs. Add git tag files for third-party minimum supported, stable, and latest git tags

…alls.

…lect individual third party packages for install

… tags are set before adding external projects from github repositories

dbarker · 2025-06-21T02:11:07Z

.devcontainer/Dockerfile.dev

 COPY ./.devcontainer/customize_container.sh /tmp/opentelemetry_cpp/devcontainer/customize_container.sh
 RUN /tmp/opentelemetry_cpp/devcontainer/customize_container.sh
 RUN apt install -y npm && npm install -g [email protected]

 USER devuser

 WORKDIR  /workspaces/opentelemetry-cpp
+RUN cd /opt && bash ci/install_thirdparty.sh --install-dir /home/devuser/third-party/install-stable --tags-file install/cmake/third_party_stable


Installing the dependencies with user privileges and under the /home/devuser directory then setting CMAKE_PREFIX_PATH makes it easier for developers to change/test versions of dependencies in the devcontainer.

dbarker · 2025-06-21T02:12:35Z

.github/workflows/ci.yml

@@ -84,32 +82,25 @@ jobs:
  cmake_gcc_maintainer_sync_test:
    name: CMake gcc 14 (maintainer mode, sync)
    runs-on: ubuntu-24.04
+    env:


Moving the environment variables to the job level ensures the dependencies and otel-cpp are built with the same c++ standard and compiler.

dbarker · 2025-06-21T02:13:50Z

.github/workflows/ci.yml

@@ -951,7 +911,7 @@ jobs:

    - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
    - name: setup
-      run: sudo apt remove needrestart && sudo ./ci/install_format_tools.sh #refer: https://github.com/actions/runner-images/issues/9937
+      run: sudo ./ci/install_format_tools.sh


The needrestart package no longer needs to be removed. Opportunistic cleanup.

dbarker · 2025-06-21T02:23:09Z

install/cmake/third_party_latest

@@ -0,0 +1,18 @@
+# Copyright The OpenTelemetry Authors


There are four files now with git tags for third-party repositories. The intent is to move all third party versions out of github workflow yml files into these tag files.

third_party_release

install/cmake/third_party_minimum

install/cmake/third_party_stable

install/cmake/third_party_latest

In the future we can consider maintaining third_party_release as the "latest" versions while keeping the third_party_minimum version file to test the range supported. Then it seems reasonable to remove the "stable" and "latest" files.

dbarker · 2025-06-21T02:28:58Z

third_party_release


-gRPC=v1.49.2
-abseil=20240116.1
+abseil=20220623.2


Updated this file to add the missing dependencies. The intent is to not upgrade anything in this file with this PR.

Git tags for curl and zlib were selected with no strong rationale (interested in feedback on what these should be).

Git tags for abseil and protobuf were selected based on the grpc submodule versions at the grpc tag.

owent

Excellent work, LGTM.

marcalff

LGTM, nice work.

dbarker changed the title ~~Add thirdparty install cmake project and install bash script. Use the…~~ [CMAKE] Add thirdparty install cmake project and install bash script Jun 17, 2025

dbarker added 3 commits June 20, 2025 12:50

Add thirdparty install cmake project and install bash script. Use the…

6fa34e6

… script to replace the setup_grpc, install_abseil, setup_googletest, and install_protobuf scripts in ci jobs. Add git tag files for third-party minimum supported, stable, and latest git tags

fix ci issues. set cxx standard to 14 by default for third party inst…

803be42

…alls.

Improve argument handling in install_thirdparty.sh. Add support to se…

23f4d8a

…lect individual third party packages for install

dbarker force-pushed the cmake_add_thirdparty_install_project branch from 212fdd6 to 23f4d8a Compare June 20, 2025 22:02

dbarker added 2 commits June 20, 2025 19:40

Add comments to the third-party install cmake project file. Check git…

bbe0260

… tags are set before adding external projects from github repositories

fix third-party install cmake project

6ec4b03

dbarker commented Jun 21, 2025

View reviewed changes

dbarker marked this pull request as ready for review June 21, 2025 02:30

dbarker requested a review from a team as a code owner June 21, 2025 02:30

dbarker mentioned this pull request Jun 23, 2025

[CMAKE] clean up googletest and benchmark dependency management #3485

Merged

3 tasks

owent approved these changes Jun 24, 2025

View reviewed changes

Merge branch 'main' into cmake_add_thirdparty_install_project

504606c

marcalff approved these changes Jun 25, 2025

View reviewed changes

marcalff added the ok-to-merge The PR is ok to merge (has two approves or raised by a maintainer/approver and has one approve) label Jun 25, 2025

Merge branch 'main' into cmake_add_thirdparty_install_project

ad724fe

marcalff merged commit 29c0dd4 into open-telemetry:main Jun 25, 2025
70 checks passed

dbarker mentioned this pull request Jun 27, 2025

[CMAKE] Unify third party dependency management #3460

Closed

3 tasks

dbarker deleted the cmake_add_thirdparty_install_project branch July 10, 2025 16:44

BrewTestBot mentioned this pull request Jul 11, 2025

opentelemetry-cpp 1.22.0 Homebrew/homebrew-core#229832

Merged

dbarker mentioned this pull request Jul 15, 2025

[REMOVAL] remove unused ci bash scripts #3541

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[CMAKE] Add thirdparty install cmake project and install bash script #3486

[CMAKE] Add thirdparty install cmake project and install bash script #3486

Uh oh!

dbarker commented Jun 17, 2025

Uh oh!

netlify bot commented Jun 17, 2025 •

edited

Loading

Uh oh!

codecov bot commented Jun 17, 2025 •

edited

Loading

Uh oh!

dbarker Jun 21, 2025

Uh oh!

dbarker Jun 21, 2025

Uh oh!

dbarker Jun 21, 2025

Uh oh!

dbarker Jun 21, 2025

Uh oh!

dbarker Jun 21, 2025

Uh oh!

owent left a comment

Uh oh!

marcalff left a comment

Uh oh!

Uh oh!

Uh oh!

[CMAKE] Add thirdparty install cmake project and install bash script #3486

[CMAKE] Add thirdparty install cmake project and install bash script #3486

Uh oh!

Conversation

dbarker commented Jun 17, 2025

Changes

Uh oh!

netlify bot commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.

Uh oh!

codecov bot commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

dbarker Jun 21, 2025

Choose a reason for hiding this comment

Uh oh!

dbarker Jun 21, 2025

Choose a reason for hiding this comment

Uh oh!

dbarker Jun 21, 2025

Choose a reason for hiding this comment

Uh oh!

dbarker Jun 21, 2025

Choose a reason for hiding this comment

Uh oh!

dbarker Jun 21, 2025

Choose a reason for hiding this comment

Uh oh!

owent left a comment

Choose a reason for hiding this comment

Uh oh!

marcalff left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

netlify bot commented Jun 17, 2025 •

edited

Loading

codecov bot commented Jun 17, 2025 •

edited

Loading