Skip to content

Conversation

dbarker
Copy link
Member

@dbarker dbarker commented Jun 15, 2025

Fixes #3480

Changes

  • revert explicitly installing cmake with the setup_cmake scripts. (except for one runner to test the minimum version of cmake).

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

Copy link

netlify bot commented Jun 15, 2025

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit 7112179
🔍 Latest deploy log https://app.netlify.com/projects/opentelemetry-cpp-api-docs/deploys/684f30f8b03c860008dcfe37

Copy link

codecov bot commented Jun 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.91%. Comparing base (47f530a) to head (7112179).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3482      +/-   ##
==========================================
- Coverage   89.97%   89.91%   -0.05%     
==========================================
  Files         219      219              
  Lines        7042     7042              
==========================================
- Hits         6335     6331       -4     
- Misses        707      711       +4     

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dbarker dbarker marked this pull request as ready for review June 15, 2025 22:10
@dbarker dbarker requested a review from a team as a code owner June 15, 2025 22:10
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcalff marcalff merged commit 7a68bb3 into open-telemetry:main Jun 16, 2025
67 checks passed
@dbarker dbarker deleted the ci_remove_cmake_script_usage branch July 10, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] unpin cmake in ci and devcontainer
2 participants