Skip to content

Conversation

marcalff
Copy link
Member

@marcalff marcalff commented May 6, 2024

Fixes #2658

Changes

Please provide a brief description of the changes here.

  • Add an explicit dependency to nlohmann_json in test otlp_file_client_test.
  • This is required to build with non standard install locations.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff marcalff marked this pull request as ready for review May 6, 2024 22:35
@marcalff marcalff requested a review from a team May 6, 2024 22:35
@marcalff marcalff added the pr:please-review This PR is ready for review label May 8, 2024
Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.57%. Comparing base (497eaf4) to head (a408c4e).
Report is 59 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2659      +/-   ##
==========================================
+ Coverage   87.12%   87.57%   +0.46%     
==========================================
  Files         200      188      -12     
  Lines        6109     5848     -261     
==========================================
- Hits         5322     5121     -201     
+ Misses        787      727      -60     

see 55 files with indirect coverage changes

@marcalff marcalff merged commit 6de4ccd into open-telemetry:main May 8, 2024
@marcalff marcalff deleted the fix_otlp_file_test_2658 branch June 3, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:please-review This PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUILD] Build break in OLTP_FILE tests
2 participants