-
Notifications
You must be signed in to change notification settings - Fork 497
Description
Describe your environment I happened to notice this in a large Bazel-based repository that I'm in the middle of converting from WORKSPACE to bzlmod. I happened to have rules_foreign_cc enabled under bzmod, but opentelemetry-cpp was still enabled under WORKSPACE. In this case, I ended up with two instances of rules_foreign_cc at wildly different versions, and hilarity ensued. I tracked down the version still coming from WORKSPACE to opentelemetry-cpp. Based on a look at the opentelemetry-cpp code, I suspect that this is a stale definition that is no longer actually needed.
Steps to reproduce
If you set up a Bazel WORKSPACE as described at https://github.com/open-telemetry/opentelemetry-cpp/blob/main/INSTALL.md#incorporating-into-an-existing-bazel-project you'll observe that your build now has a definition for an external repository named rules_foreign_cc
that it did not before.
What is the expected behavior?
I would not have expected to see this, since rules_foreign_cc
is not among the documented deps for opentelemetry-cpp at https://registry.bazel.build/modules/opentelemetry-cpp (for consuming opentelemetry with Bazel under bzlmod rather than WORKSPACE).
What is the actual behavior?
Described above.
Additional context
Add any other context about the problem here.
Tip: React with 👍 to help prioritize this issue. Please use comments to provide useful context, avoiding +1
or me too
, to help us triage it. Learn more here.