fix: update attribute_keys to include type #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the stream's `attribute_keys` configuration to an include/exclude style object that currently only supports `included`. This is in hope to support `excluded` in the future once the specification allows it. Fixes open-telemetry#98 Signed-off-by: Alex Boten <[email protected]>
codeboten
commented
Aug 19, 2024
MrAlias
reviewed
Aug 19, 2024
Co-authored-by: Tyler Yahn <[email protected]>
MrAlias
approved these changes
Aug 19, 2024
jack-berg
reviewed
Aug 20, 2024
codeboten
commented
Aug 20, 2024
jack-berg
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the stream's
attribute_keysconfiguration to an include/exclude style object that currently only supportsincluded. This is in hope to supportexcludedin the future once the specification allows it.Fixes #98