Move packages out of pkg to root
#73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moved /pkg/factories and /pkg/configv2 to /factories and /configv2 respectively. - Moved /pkg/configmodels to /models
owais
requested review from
bogdandrutu,
flands,
pjanotti,
songy23 and
tigrannajaryan
as code owners
Codecov Report
@@ Coverage Diff @@
## master #73 +/- ##
=======================================
Coverage 71.37% 71.37%
=======================================
Files 91 91
Lines 6022 6022
=======================================
Hits 4298 4298
Misses 1500 1500
Partials 224 224
Continue to review full report at Codecov.
|
|
Can we use |
|
Took a quick look and don't why not but it'll need more careful update as quite a few files are using |
|
@tigrannajaryan that can be done in a separate PR. I would like to keep the PRs very granular. |
songy23
approved these changes
Jun 28, 2019
pjanotti
referenced
this pull request
in pjanotti/opentelemetry-service
Jul 1, 2019
* Minimize the Docker image Use a builder stage to minimize the final Docker image. docker run -v config.yaml:/config.yaml -p 55678:55678 <image> Fixes #73. * Use Go.11
6 tasks
jjackson-s
pushed a commit
to jjackson-s/opentelemetry-collector
that referenced
this pull request
Jul 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
respectively.
Discussed here: #69