Standarize Settings instead of Params and Parameters #2991
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bogdandrutu @tigrannajaryan please take a look for this proposal |
Codecov Report
@@ Coverage Diff @@
## main #2991 +/- ##
==========================================
- Coverage 92.06% 91.65% -0.42%
==========================================
Files 313 312 -1
Lines 15439 15428 -11
==========================================
- Hits 14214 14140 -74
- Misses 817 881 +64
+ Partials 408 407 -1
Continue to review full report at Codecov.
|
pmatyjasek-sumo
force-pushed
the
pm_standarize_constructor_settings
branch
2 times, most recently
from
2aa2886 to
72ef9d6
Compare
Fixes open-telemetry#2650 Changes: Replace: ReceiverCreateParams, ProcessorCreateParams, ExtensionCreateParams and ExporterCreateParams with ComponentSettings struct Replace all dependencies in Extensions, Exporters, Processors and Receivers Replace Parameters and settings structs with new struct Settings Replace dependencies in service and main Update tests Signed-off-by: Patryk Matyjasek <[email protected]> # Conflicts: # exporter/kafkaexporter/factory.go # exporter/kafkaexporter/factory_test.go # exporter/kafkaexporter/kafka_exporter.go # exporter/kafkaexporter/kafka_exporter_test.go # exporter/prometheusexporter/factory.go # receiver/jaegerreceiver/jaeger_agent_test.go # receiver/jaegerreceiver/trace_receiver_test.go # receiver/kafkareceiver/factory.go # receiver/kafkareceiver/factory_test.go # receiver/kafkareceiver/kafka_receiver.go # receiver/kafkareceiver/kafka_receiver_test.go # Conflicts: # processor/batchprocessor/batch_processor.go # processor/batchprocessor/batch_processor_test.go # processor/batchprocessor/factory.go # processor/filterprocessor/filter_processor_test.go # service/application.go # Conflicts: # cmd/otelcol/main.go # component/component.go # component/exporter.go # component/extension.go # component/processor.go # component/processor_test.go # component/receiver.go # exporter/exporterhelper/factory_test.go # extension/extensionhelper/factory_test.go # processor/batchprocessor/batch_processor.go # processor/processorhelper/factory_test.go # receiver/jaegerreceiver/factory.go # receiver/jaegerreceiver/trace_receiver_test.go # receiver/otlpreceiver/factory.go # receiver/prometheusreceiver/factory.go # receiver/receiverhelper/factory_test.go # service/application.go # service/application_test.go # service/defaultcomponents/default_exporters_test.go # service/defaultcomponents/default_extensions_test.go # service/defaultcomponents/default_processors_test.go # service/defaultcomponents/default_receivers_test.go # service/internal/builder/exporters_builder.go # service/internal/builder/extensions_builder.go # service/internal/builder/pipelines_builder.go # service/internal/builder/receivers_builder.go # service/service.go # service/service_test.go # testbed/testbed/otelcol_runner.go
Fix Windows building Signed-off-by: Patryk Matyjasek <[email protected]> # Conflicts: # CHANGELOG.md
pmatyjasek-sumo
force-pushed
the
pm_standarize_constructor_settings
branch
from
72ef9d6 to
44f32bb
Compare
bogdandrutu
reviewed
May 12, 2021
|
Thanks @bogdandrutu for the response. I'll split it into smaller PRs. |
This was referenced May 13, 2021
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
@pmatyjasek-sumo is this PR still useful? |
|
No. I'm closing it |
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A proposal solution of standarize constructors parameters
Description:
Fixes #2650
Changes:
Replace: ReceiverCreateParams, ProcessorCreateParams, ExtensionCreateParams and ExporterCreateParams with ComponentSettings struct
Replace all dependencies in Extensions, Exporters, Processors and Receivers
Replace Parameters and settings structs with new struct Settings
Replace dependencies in service and main
Update tests
Signed-off-by: Patryk Matyjasek [email protected]
Link to tracking Issue:
#2650
Testing: < Describe what testing was performed and which tests were added.>
UT
Documentation: < Describe the documentation added.>
In code comments