Skip to content

Conversation

dmitryax
Copy link
Member

@dmitryax dmitryax commented Oct 6, 2025

To unblock #13933

The logic seems incorrect. The check should run when

(!startsWith(title, '[chore] Prepare release')) || (user != 'otelbot[bot]')

or 

!(startsWith(title, '[chore] Prepare release')) && (user == 'otelbot[bot]'))

instead of

(!startsWith(title, '[chore] Prepare release')) || (user == 'otelbot[bot]')

@dmitryax dmitryax requested a review from a team as a code owner October 6, 2025 18:03
@dmitryax dmitryax requested a review from mx-psi October 6, 2025 18:03
@dmitryax dmitryax closed this Oct 6, 2025
@dmitryax dmitryax reopened this Oct 6, 2025
@codeboten codeboten enabled auto-merge October 6, 2025 18:11
Copy link

codecov bot commented Oct 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.66%. Comparing base (d00f059) to head (4b5379f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13934   +/-   ##
=======================================
  Coverage   91.65%   91.66%           
=======================================
  Files         652      652           
  Lines       42516    42516           
=======================================
+ Hits        38970    38974    +4     
+ Misses       2736     2733    -3     
+ Partials      810      809    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codeboten codeboten added this pull request to the merge queue Oct 6, 2025
Merged via the queue into open-telemetry:main with commit 5a4966e Oct 6, 2025
85 of 115 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 6, 2025
@dmitryax dmitryax deleted the fix-github/workflows/check-merge-freeze branch October 6, 2025 19:00
@dmitryax dmitryax restored the fix-github/workflows/check-merge-freeze branch October 6, 2025 19:00
@dmitryax dmitryax deleted the fix-github/workflows/check-merge-freeze branch October 6, 2025 19:00
@jade-guiton-dd
Copy link
Contributor

Sorry about that mistake 😓 The logic for that condition changed so many times I got confused

@dmitryax
Copy link
Member Author

dmitryax commented Oct 7, 2025

@jade-guiton-dd no worries at all :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants