internal/cmd/pdatagen: add support for specifying a work dir #13890
+17
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new flag (
-C path
) to thepdatagen
utility, which allows specifying the workdir for the tool.Currently
pdatagen
expects to find the respective files inpdata
directory of the$cwd
. Whenpdatagen
is called outside of the$repo_root
the tool fails, because it cannot findpdata
and panics.This PR adds an optional
-C path
flag, which would allowpdatagen
to use an alternative workdir, and also be able to be called outside of the$repo_root
directory.See #13844 for more details about this PR and the proposed changes. The commit from this PR have been extracted from #13844 .
Link to tracking issue
Testing
Documentation