[chore] service/telemetry: split providers interface back apart #13739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axw
force-pushed
the
telemetry-interface-take2
branch
2 times, most recently
from
6a76c64 to
0253c7e
Compare
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (94.73%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #13739 +/- ##
==========================================
+ Coverage 91.38% 91.40% +0.02%
==========================================
Files 647 646 -1
Lines 42597 42605 +8
==========================================
+ Hits 38927 38944 +17
+ Misses 2845 2838 -7
+ Partials 825 823 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
axw
added a commit
to axw/opentelemetry-collector
that referenced
this pull request
Sep 4, 2025
Prep work for open-telemetry#13722, to split apart the Providers interface into per-signal providers. In a followup, I will update the telemetry.Factory interface. See open-telemetry#13739 for the end result.
axw
added a commit
to axw/opentelemetry-collector
that referenced
this pull request
Sep 4, 2025
Prep work for open-telemetry#13722, to split apart the Providers interface into per-signal providers. In a followup, I will update the telemetry.Factory interface. See open-telemetry#13739 for the end result.
axw
added a commit
to axw/opentelemetry-collector
that referenced
this pull request
Sep 4, 2025
Prep work for open-telemetry#13722, to split apart the Providers interface into per-signal providers. In a followup, I will update the telemetry.Factory interface. See open-telemetry#13739 for the end result.
axw
added a commit
to axw/opentelemetry-collector
that referenced
this pull request
Sep 4, 2025
Prep work for open-telemetry#13722, to split apart the Providers interface into per-signal providers. In a followup, I will update the telemetry.Factory interface. See open-telemetry#13739 for the end result.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 11, 2025
#### Description Refactor the internals of the package to create independent SDKs for each of the logger, meter, and tracer providers. I have introduced new interfaces to the telemetry package to expose the Shutdown methods. This will be important once we return the providers directly - they will need to support being independently shut down. This is prep work for #13722, to split apart the `telemetry.Providers` interface into per-signal providers. In a followup, I will update the telemetry.Factory interface. See #13739 for the end result. #### Link to tracking issue Part of #13722 #### Testing Unit tests only. #### Documentation N/A
axw
force-pushed
the
telemetry-interface-take2
branch
from
349200e to
855ec91
Compare
axw
force-pushed
the
telemetry-interface-take2
branch
from
855ec91 to
5e23fb7
Compare
mx-psi
reviewed
Sep 12, 2025
mx-psi
approved these changes
Sep 12, 2025
Merged
via the queue into
open-telemetry:main
with commit Sep 12, 2025
2710536
56 of 58 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Split the monolithic Providers interface back into signal-specific interfaces and associated factory methods. This will enable the Factory interface to be expanded over time, without breaking changes. This should be the last major interface refactor for telemetry 🤞
Link to tracking issue
Fixes #13722
Testing
N/A
Documentation
N/A