Skip to content

Conversation

axw
Copy link
Contributor

@axw axw commented Aug 28, 2025

Description

Introduce a new Factory interface for constructing telemetry providers. This will enable overriding telemetry providers in a followup. The Factory interface is likely to change in a followup, see #13722

Link to tracking issue

Part of #4970

Testing

Unit tests added.

Documentation

N/A

@axw axw force-pushed the service-telemetry-interface branch from 7cf4442 to 5c02157 Compare August 28, 2025 00:11
Copy link

codecov bot commented Aug 28, 2025

Codecov Report

❌ Patch coverage is 96.77419% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 91.51%. Comparing base (822643b) to head (331fa14).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
service/telemetry/telemetry.go 96.55% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13725      +/-   ##
==========================================
- Coverage   91.52%   91.51%   -0.02%     
==========================================
  Files         640      640              
  Lines       42495    42508      +13     
==========================================
+ Hits        38894    38900       +6     
- Misses       2782     2787       +5     
- Partials      819      821       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@axw axw force-pushed the service-telemetry-interface branch from 5c02157 to 3059ca2 Compare August 28, 2025 00:34
@axw axw force-pushed the service-telemetry-interface branch from 3059ca2 to 331fa14 Compare August 28, 2025 03:04
@axw axw marked this pull request as ready for review August 28, 2025 03:29
@axw axw requested a review from a team as a code owner August 28, 2025 03:29
@axw axw requested a review from songy23 August 28, 2025 03:29
@mx-psi mx-psi added this pull request to the merge queue Aug 28, 2025
Merged via the queue into open-telemetry:main with commit 3d3d087 Aug 28, 2025
87 of 92 checks passed
@github-actions github-actions bot added this to the next release milestone Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants