Skip to content

Conversation

bogdandrutu
Copy link
Member

The main idea is that the [*]otlp/Request is for http/grpc OTLP communication, but the Marshaler is only marshaling non-protocol specific data.

@bogdandrutu bogdandrutu requested review from mx-psi, dmathieu, a team and dmitryax as code owners August 27, 2025 17:52
Copy link

codecov bot commented Aug 27, 2025

Codecov Report

❌ Patch coverage is 72.72727% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.52%. Comparing base (5a5da91) to head (c6f69d2).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pdata/plog/plogotlp/request.go 72.72% 2 Missing and 1 partial ⚠️
pdata/pmetric/pmetricotlp/request.go 72.72% 2 Missing and 1 partial ⚠️
pdata/pprofile/pprofileotlp/request.go 72.72% 2 Missing and 1 partial ⚠️
pdata/ptrace/ptraceotlp/request.go 72.72% 2 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (72.72%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13724      +/-   ##
==========================================
- Coverage   91.66%   91.52%   -0.14%     
==========================================
  Files         639      640       +1     
  Lines       42423    42495      +72     
==========================================
+ Hits        38887    38894       +7     
- Misses       2710     2782      +72     
+ Partials      826      819       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bogdandrutu bogdandrutu enabled auto-merge August 27, 2025 22:22
@bogdandrutu bogdandrutu added this pull request to the merge queue Aug 27, 2025
Merged via the queue into open-telemetry:main with commit 822643b Aug 27, 2025
54 of 57 checks passed
@bogdandrutu bogdandrutu deleted the small-nits-josn branch August 27, 2025 22:57
@github-actions github-actions bot added this to the next release milestone Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants