[service] ensure insecure config is taken into consideration #13691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the function that normalizes the endpoint to consider the setting for `insecure` when prefixing the endpoint. Signed-off-by: alex boten <[email protected]>
Signed-off-by: alex boten <[email protected]>
Signed-off-by: alex boten <[email protected]>
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (76.92%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #13691 +/- ##
==========================================
- Coverage 91.58% 91.57% -0.01%
==========================================
Files 639 639
Lines 42261 42264 +3
==========================================
Hits 38703 38703
- Misses 2725 2726 +1
- Partials 833 835 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mx-psi
approved these changes
Aug 25, 2025
Merged
via the queue into
open-telemetry:main
with commit Aug 25, 2025
4b5e356
54 of 57 checks passed
codeboten
added a commit
to codeboten/opentelemetry-collector-contrib
that referenced
this pull request
Aug 25, 2025
This updates the test configuration to explicitly set the endpoint to insecure. This will address a test failure caused by open-telemetry/opentelemetry-collector#13691 Signed-off-by: alex boten <[email protected]>
songy23
pushed a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Aug 25, 2025
This updates the test configuration to explicitly set the endpoint to insecure. This will address a test failure caused by open-telemetry/opentelemetry-collector#13691 Signed-off-by: alex boten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the function that normalizes the endpoint to consider the setting for
insecurewhen prefixing the endpoint.Fixes #13690