Skip to content

Conversation

iblancasa
Copy link
Contributor

This is part of #13106
It introduces a new MergeFrom method, which allows merging to profiles.

@iblancasa iblancasa requested review from a team, dmathieu and mx-psi as code owners August 7, 2025 13:57
Copy link

codecov bot commented Aug 7, 2025

Codecov Report

❌ Patch coverage is 76.75545% with 96 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.43%. Comparing base (2e19689) to head (dc44db8).
⚠️ Report is 104 commits behind head on main.

Files with missing lines Patch % Lines
pdata/pprofile/merge.go 76.75% 64 Missing and 32 partials ⚠️

❌ Your patch status has failed because the patch coverage (76.75%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13588      +/-   ##
==========================================
- Coverage   91.57%   91.43%   -0.15%     
==========================================
  Files         639      640       +1     
  Lines       42153    42566     +413     
==========================================
+ Hits        38603    38920     +317     
- Misses       2719     2783      +64     
- Partials      831      863      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@iblancasa iblancasa force-pushed the 13106 branch 4 times, most recently from 87728f8 to 0f39e3a Compare August 8, 2025 13:16
Signed-off-by: Israel Blancas <[email protected]>
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Aug 23, 2025
@github-actions github-actions bot removed the Stale label Aug 26, 2025
@dmathieu
Copy link
Member

Couldn't the logic be simplified by using the Set* methods introduced earlier? (that's the reason they were introduced)

Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Sep 12, 2025
Copy link
Contributor

github-actions bot commented Oct 2, 2025

Closed as inactive. Feel free to reopen if this PR is still being worked on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants