-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[chore] Move service/telemetry implementation #13560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4c8305d
to
974d339
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13560 +/- ##
==========================================
- Coverage 92.24% 92.23% -0.02%
==========================================
Files 605 605
Lines 31909 31911 +2
==========================================
- Hits 29435 29433 -2
- Misses 1952 1955 +3
- Partials 522 523 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Move the implementation to service/telemetry/otelconftelemetry. For now I've moved everything except for Settings. I'll introduce a new Factory and Telemetry interface in a followup, and remove the Factory interface from otelconftelemetry.
// NewFactory creates a new Factory. | ||
func NewFactory() Factory { | ||
// | ||
// TODO remove the sdk and res parameters once the factory is fully |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a reference to an issue tracking this here and in the other TODO?
I would also add a proper godoc comment that says "this is experimental and will change soon use at your own risk"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. I've linked to #4970, and added some NOTEs to warn against use in the mean time.
Signed-off-by: Bence Csati <[email protected]>
Description
Move the telemetry implementation from
service/telemetry
toservice/telemetry/otelconftelemetry
, with the exception of the Settings type which is intended to remain in theservice/telemetry
package permanently. The goal here is to separate the interface (which is to be defined in a followup) and implementation, so multiple implementations can exist.This move is in preparation for creating a new Telemetry and Factory interface, similar to pipeline components. In the end, the implementation (e.g. otelconftelemetry) will be completely self contained, providing a NewFactory function to obtain a factory that can be used to construct a Telemetry implementation.
The next steps after this PR would be:
service/telemetry
#8170.Link to tracking issue
Part of #4970
Testing
N/A, non-functional change.
Documentation
N/A