-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[confmap][PoC] - Showcase the use of yaml tags for merge append mode #13551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (93.10%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #13551 +/- ##
==========================================
- Coverage 91.50% 90.88% -0.63%
==========================================
Files 526 599 +73
Lines 29436 31460 +2024
==========================================
+ Hits 26936 28592 +1656
- Misses 1971 2333 +362
- Partials 529 535 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- name: merge-mode-default | ||
configs: | ||
- | ||
- | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this is only needed for the test cases and not in an actual config file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, only for test file. I changed this because I wanted the config to be a "string" and not a map.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason for doing this:
If we don't specify this as a "string", the yaml tags would get lost in json translation.
In real world configuration, this would not happen because of obvious reasons (we load config from yaml file and tags are preserved).
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Description
This POC PR implements the merging of lists by utilizing the yaml tags. This method makes very little changes to public API and completely relies on the information provided from the confi files.
We following these steps:
Relates #13256