[processorhelper] Add throughput metrics #11147
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11147 +/- ##
==========================================
- Coverage 92.28% 92.21% -0.08%
==========================================
Files 413 413
Lines 19760 19798 +38
==========================================
+ Hits 18236 18256 +20
- Misses 1152 1164 +12
- Partials 372 378 +6 ☔ View full report in Codecov by Sentry. |
djaglowski
force-pushed
the
processor-throughput-metrics
branch
from
c30fa02 to
94bd623
Compare
djaglowski
force-pushed
the
processor-throughput-metrics
branch
from
94bd623 to
e811026
Compare
codeboten
reviewed
Sep 13, 2024
There was a problem hiding this comment.
Thanks @djaglowski, using the level is ok for now, we'll have to change it once the level is removed but it's a minor change.
For testing, you can look at the batch processor tests which include detailed metrics
Co-authored-by: Alex Boten <[email protected]>
Co-authored-by: Alex Boten <[email protected]>
Co-authored-by: Alex Boten <[email protected]>
djaglowski
force-pushed
the
processor-throughput-metrics
branch
from
261684b to
76ae166
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows up #10910.
I expect to revamp this if #11144 is merged, but I wanted to put it out in order to get feedback (cc @codeboten) on whether this is currently the way to implement detailed metrics.
It also still requires tests, but I'm unclear if the generated test code is intended to allow testing of detailed metrics yet.