Skip to content

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Aug 30, 2024

Description

Fixes #11022

@mx-psi mx-psi marked this pull request as ready for review August 30, 2024 10:42
@mx-psi mx-psi requested review from a team and atoulme August 30, 2024 10:42
@mx-psi mx-psi requested a review from codeboten August 30, 2024 10:42
@mx-psi
Copy link
Member Author

mx-psi commented Aug 30, 2024

@codeboten Should we rename to extension/storage? I remember with the internal/featuregates separation into a module using the same name was a concern, so I wonder if this is also something we should address here

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.22%. Comparing base (c4e527e) to head (492ab78).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11020   +/-   ##
=======================================
  Coverage   92.22%   92.22%           
=======================================
  Files         408      408           
  Lines       19126    19126           
=======================================
  Hits        17639    17639           
  Misses       1126     1126           
  Partials      361      361           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codeboten Should we rename to extension/storage? I remember with the internal/featuregates separation into a module using the same name was a concern, so I wonder if this is also something we should address here

@mx-psi i seem to recall this was only a problem if a package the collector contrib repo depends on also depends on the internal package being created. If not it's not an issue i think, we can always prove this by merging the change as is, and updating contrib to see if it fails w/ the errors we were seeing w/ featuregates

@mx-psi
Copy link
Member Author

mx-psi commented Sep 2, 2024

Alright, I am going to try merging this then and if the make update-otel goes well

@mx-psi mx-psi merged commit cd1f762 into open-telemetry:main Sep 2, 2024
48 of 49 checks passed
@mx-psi mx-psi deleted the mx-psi/experimental-storage-module branch September 2, 2024 08:56
@github-actions github-actions bot added this to the next release milestone Sep 2, 2024
@mx-psi
Copy link
Member Author

mx-psi commented Sep 2, 2024

Need #11029 next

mx-psi added a commit that referenced this pull request Sep 2, 2024
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Follow up to #11020, needed for
open-telemetry/opentelemetry-collector-contrib/pull/34956.

Updates all pseudoversions to point to cd1f762
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move extension/experimental/storage to a separate module
3 participants