-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[extension] Split extension/experimental/storage into a separate module #11020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[extension] Split extension/experimental/storage into a separate module #11020
Conversation
|
@codeboten Should we rename to |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11020 +/- ##
=======================================
Coverage 92.22% 92.22%
=======================================
Files 408 408
Lines 19126 19126
=======================================
Hits 17639 17639
Misses 1126 1126
Partials 361 361 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@codeboten Should we rename to extension/storage? I remember with the internal/featuregates separation into a module using the same name was a concern, so I wonder if this is also something we should address here
@mx-psi i seem to recall this was only a problem if a package the collector contrib repo depends on also depends on the internal package being created. If not it's not an issue i think, we can always prove this by merging the change as is, and updating contrib to see if it fails w/ the errors we were seeing w/ featuregates
|
Alright, I am going to try merging this then and if the |
|
Need #11029 next |
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Follow up to #11020, needed for open-telemetry/opentelemetry-collector-contrib/pull/34956. Updates all pseudoversions to point to cd1f762
Description
Fixes #11022