Moved tools/tools.go to internal package #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owais
requested review from
bogdandrutu,
flands,
pjanotti,
songy23 and
tigrannajaryan
as code owners
songy23
previously approved these changes
Jul 3, 2019
bogdandrutu
previously approved these changes
Jul 3, 2019
pjanotti
reviewed
Jul 3, 2019
internal/tools.go
Outdated
| // https://github.com/golang/go/wiki/Modules#how-can-i-track-tool-dependencies-for-a-module | ||
| // on how to add tooling dependencies. | ||
| package tools | ||
| // on how to ping add tooling dependencies to a go.mod file. |
Codecov Report
@@ Coverage Diff @@
## master #108 +/- ##
=======================================
Coverage 69.77% 69.77%
=======================================
Files 101 101
Lines 6392 6392
=======================================
Hits 4460 4460
Misses 1698 1698
Partials 234 234Continue to review full report at Codecov.
|
Also ran `go mod tidy` Fixes #102
tigrannajaryan
approved these changes
Jul 3, 2019
6 tasks
bogdandrutu
approved these changes
Jul 3, 2019
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
…metry#108) * Add a YAML getting started to deploy splunk-otel-collector Example is only for gateway mode. Also update README and consolidate Docker docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also ran
go mod tidyFixes #102