-
Notifications
You must be signed in to change notification settings - Fork 3.1k
[receiver/ciscoosreceiver] Add SSH connection implementation #43384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/ciscoosreceiver] Add SSH connection implementation #43384
Conversation
| value_type: int | ||
| enabled: true | ||
| attributes: [interface.name, interface.state] | ||
| cisco.system.cpu.utilization: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the utilization value returned as a pre-aggregated value from the device or we will be doing the temporal aggregation in the receiver keeping the state between the scrapes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The device gives current values at each scrape — not a pre-aggregated value. The receiver doesn’t track past data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean the utilization typically is a temporally pre-aggregated value over raw CPU time counter. If that's what is returned, we're good. We can reconsider in the implementation if needed
26bafaa to
d4a84de
Compare
d4a84de to
f8f1a67
Compare
|
Thank you for your contribution @etserend! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. If you are getting started contributing, you can also join the CNCF Slack channel #opentelemetry-new-contributors to ask for guidance and get help. |
…lemetry#43384) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Add SSH connection implementation for the Cisco OS receiver to collect metrics from Cisco devices via SSH. This PR enhances the receiver with: - **SSH client infrastructure** with password/key authentication - **Semantic configuration** using `device.host.*` and `auth.*` conventions - **Modular scrapers** for system and interface metrics - **Complete metadata definitions** with generated code - **Proper validation** and error handling <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue open-telemetry#42647 <!--Describe what testing was performed and which tests were added.--> #### Testing - Unit tests for config validation, factory, and SSH connections - All repository checks passing: make generate, make checkdoc, make checkmetadata - Generated lifecycle tests via mdatagen <!--Describe the documentation added.--> #### Documentation - Complete README with configuration examples and metrics documentation - metadata.yaml - with interface and system metric definitions - Changelog entry added
Description
Add SSH connection implementation for the Cisco OS receiver to collect metrics from Cisco devices via SSH.
This PR enhances the receiver with:
device.host.*andauth.*conventionsLink to tracking issue
#42647
Testing
Documentation