metricstarttimeprocessor: cache both int and double value for the sum datapoint #42203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ridwanmsharif
force-pushed
the
ridwanmsharif/fix-adjust-int-sums
branch
from
d9a8248 to
2a4d69f
Compare
dashpole
reviewed
Aug 26, 2025
processor/metricstarttimeprocessor/internal/datapointstorage/timeseries_map.go
Show resolved
Hide resolved
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Moving to draft while comments and CI are addressed. Please address and mark ready to review again. |
ridwanmsharif
force-pushed
the
ridwanmsharif/fix-adjust-int-sums
branch
2 times, most recently
from
8ebdf0a to
f756123
Compare
… datapoint Fixes open-telemetry#42202. Signed-off-by: Ridwan Sharif <[email protected]>
ridwanmsharif
force-pushed
the
ridwanmsharif/fix-adjust-int-sums
branch
from
f756123 to
f0ec95f
Compare
dashpole
approved these changes
Oct 14, 2025
dashpole
added
the
ready to merge
ChrsMark
pushed a commit
to ChrsMark/opentelemetry-collector-contrib
that referenced
this pull request
Oct 20, 2025
… datapoint (open-telemetry#42203) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Update the timeseries info structs so we also store the int values for sums. And make sure we update and use this appropriately in the strategies. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#42202 <!--Describe what testing was performed and which tests were added.--> #### Testing Added unit tests to the datapointstorage module, as well as to each strategy. <!--Describe the documentation added.--> #### Documentation N/A <!--Please delete paragraphs that you did not use before submitting.--> Signed-off-by: Ridwan Sharif <[email protected]> Co-authored-by: David Ashpole <[email protected]> Co-authored-by: Yang Song <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the timeseries info structs so we also store the int values for sums. And make sure we update and use this appropriately in the strategies.
Link to tracking issue
Fixes #42202
Testing
Added unit tests to the datapointstorage module, as well as to each strategy.
Documentation
N/A