Skip to content

Conversation

lahsivjar
Copy link
Member

Description

Use WithQueueBatch and configure a partitioner based on metadata keys for sending_queue::batch.

Link to tracking issue

Fixes #41775

Testing

Added testcases.

Documentation

Updated

@lahsivjar lahsivjar requested review from MovieStoreGuy and a team as code owners August 5, 2025 12:12
@github-actions github-actions bot requested review from axw and pavolloffay August 5, 2025 12:12
@lahsivjar lahsivjar changed the title Kafkaexporter batcher [exporter/kafka]Switch to QueueBatch and configure partitioner Aug 5, 2025
Copy link
Contributor

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, approved by codeowner, merging.

@atoulme atoulme merged commit 2dfee84 into open-telemetry:main Aug 6, 2025
183 checks passed
atoulme pushed a commit that referenced this pull request Aug 7, 2025
…and traces (#41824)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
PR
#41776
introduced a bug where incorrect queue batch settings were used for
metrics and traces. This would result in panic due to the incorrect
encoding defined in the incorrect queue batch settings when the
`sending_queue#batch` is used with sizers that require the encoding (ex:
bytes sizer). The PR updates the test cases to catch this too.

<!-- Issue number (e.g. #1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Related to
#41775

<!--Describe what testing was performed and which tests were added.-->
#### Testing

Updated test cases.

<!--Describe the documentation added.-->
#### Documentation

Not required.

<!--Please delete paragraphs that you did not use before submitting.-->
@lahsivjar lahsivjar deleted the kafkaexporter-batcher branch August 11, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[exporter/kafka] Configure partitioner for exporter's batching
4 participants