[receiver/sqlserver] Make queries compatible with Azure SQL Database … #41102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and Azure SQL Managed Instance
github-actions
bot
added
receiver/sqlserver
Run Windows
dmitryax
approved these changes
Jul 15, 2025
dmitryax
reviewed
Jul 15, 2025
Comment on lines
+19
to
+51
| Affected metrics: | ||
| - sqlserver.database.latency | ||
| - sqlserver.database.operations | ||
| - sqlserver.database.io | ||
| - sqlserver.batch.request.rate | ||
| - sqlserver.batch.sql_compilation.rate | ||
| - sqlserver.batch.sql_recompilation.rate | ||
| - sqlserver.database.backup_or_restore.rate | ||
| - sqlserver.database.execution.errors | ||
| - sqlserver.database.full_scan.rate | ||
| - sqlserver.database.tempdb.space | ||
| - sqlserver.database.tempdb.version_store.size | ||
| - sqlserver.deadlock.rate | ||
| - sqlserver.index.search.rate | ||
| - sqlserver.lock.timeout.rate | ||
| - sqlserver.lock.wait.count | ||
| - sqlserver.lock.wait.rate | ||
| - sqlserver.login.rate | ||
| - sqlserver.logout.rate | ||
| - sqlserver.memory.grants.pending.count | ||
| - sqlserver.memory.usage | ||
| - sqlserver.page.buffer_cache.free_list.stalls.rate | ||
| - sqlserver.page.buffer_cache.hit_ratio | ||
| - sqlserver.page.lookup.rate | ||
| - sqlserver.processes.blocked | ||
| - sqlserver.replica.data.rate | ||
| - sqlserver.resource_pool.disk.throttled.read.rate | ||
| - sqlserver.resource_pool.disk.operations | ||
| - sqlserver.resource_pool.disk.throttled.write.rate | ||
| - sqlserver.table.count | ||
| - sqlserver.transaction.delay | ||
| - sqlserver.transaction.mirror_write.rate | ||
| - sqlserver.user.connection.count |
There was a problem hiding this comment.
This huge list in the CHANGELOG isn't helpful unless it clearly says how the metrics are affected. Please submit a separate PR to either remove this or clarify
atoulme
pushed a commit
that referenced
this pull request
Jul 16, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Feedback of #41102 (comment) cc @dmitryax Removing the long list as they are just supported on Azure SQL Databases and Managed Instances. No breaking change. <!-- Issue number (e.g. #1234) or full URL to issue, if applicable. --> #### Link to tracking issue n/a <!--Describe what testing was performed and which tests were added.--> #### Testing n/a <!--Describe the documentation added.--> #### Documentation n/a <!--Please delete paragraphs that you did not use before submitting.-->
dmitryax
added a commit
to signalfx/splunk-otel-collector
that referenced
this pull request
Jul 24, 2025
Pulling open-telemetry/opentelemetry-collector-contrib#41102 to 0.130.0 release
dmitryax
added a commit
to signalfx/splunk-otel-collector
that referenced
this pull request
Jul 24, 2025
Pulling open-telemetry/opentelemetry-collector-contrib#41102 to 0.130.0 release
jinja2
pushed a commit
to signalfx/splunk-otel-collector
that referenced
this pull request
Jul 24, 2025
Dylan-M
pushed a commit
to Dylan-M/opentelemetry-collector-contrib
that referenced
this pull request
Aug 5, 2025
open-telemetry#41102) …and Azure SQL Managed Instance <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Regarding IO queries, `sys.master_files` is not available on Azure managed SQL Server, hence using `sys.database_files` instead to get info from the connected database. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue n/a <!--Describe what testing was performed and which tests were added.--> #### Testing Updated <!--Describe the documentation added.--> #### Documentation Added <!--Please delete paragraphs that you did not use before submitting.-->
Dylan-M
pushed a commit
to Dylan-M/opentelemetry-collector-contrib
that referenced
this pull request
Aug 5, 2025
…telemetry#41339) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Feedback of open-telemetry#41102 (comment) cc @dmitryax Removing the long list as they are just supported on Azure SQL Databases and Managed Instances. No breaking change. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue n/a <!--Describe what testing was performed and which tests were added.--> #### Testing n/a <!--Describe the documentation added.--> #### Documentation n/a <!--Please delete paragraphs that you did not use before submitting.-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…and Azure SQL Managed Instance
Description
Regarding IO queries,
sys.master_filesis not available on Azure managed SQL Server, hence usingsys.database_filesinstead to get info from the connected database.Link to tracking issue
n/a
Testing
Updated
Documentation
Added