Skip to content

Conversation

nenadnoveljic
Copy link
Contributor

Description

Adding 'sqlserver.cpu.count' metric. The metric is important for understanding saturation and capacity planing.

@github-actions github-actions bot added receiver/sqlserver Run Windows Enable running windows test on a PR labels Jul 1, 2025
@nenadnoveljic nenadnoveljic marked this pull request as ready for review July 1, 2025 13:26
@nenadnoveljic nenadnoveljic requested a review from a team as a code owner July 1, 2025 13:26
@sincejune
Copy link
Contributor

@nenadnoveljic Could you enable this flag in the configureAllScraperMetricsAndEvents function within scraper_test.go and update the associated tests accordingly?

@nenadnoveljic
Copy link
Contributor Author

@nenadnoveljic Could you enable this flag in the configureAllScraperMetricsAndEvents function within scraper_test.go and update the associated tests accordingly?

I added the test. Thanks for the suggestion!

@nenadnoveljic
Copy link
Contributor Author

@sincejune Is there anything else for me to do in this PR?

@sincejune
Copy link
Contributor

@sincejune Is there anything else for me to do in this PR?

@nenadnoveljic Thank you, It looks good.

@nenadnoveljic nenadnoveljic changed the title Adding 'sqlserver.cpu.count' metric [receiver/sqlserver] Adding 'sqlserver.cpu.count' metric Jul 7, 2025
@songy23 songy23 merged commit c3e9687 into open-telemetry:main Jul 7, 2025
211 checks passed
@github-actions github-actions bot added this to the next release milestone Jul 7, 2025
Dylan-M pushed a commit to Dylan-M/opentelemetry-collector-contrib that referenced this pull request Aug 5, 2025
…try#41032)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Adding 'sqlserver.cpu.count' metric. The metric is important for
understanding saturation and capacity planing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
receiver/sqlserver Run Windows Enable running windows test on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants