-
Notifications
You must be signed in to change notification settings - Fork 3.1k
[processor/filter] Create With*Functions factory options to register custom OTTL funcs programatically. #40933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[processor/filter] Create With*Functions factory options to register custom OTTL funcs programatically. #40933
Conversation
|
Following up the review request @TylerHelmuth @boostchicken @mwear. |
a07bfeb to
3062e8d
Compare
928345a to
237452d
Compare
6e9cc1c to
96da8a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me. API is consistent with the transform processor one (#39698), and it worked well on my local tests. Great work @franciscovalentecastro!
@evan-bradley, you might be interested on taking a look at this one considering you also reviewed the transform processor changes :)
497562d to
596d223
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delayed review, this looks good to me. Thanks for your patience @franciscovalentecastro.
Description
Create
With*Functionsfactory options to provide custom OTTL functions for logs, metrics or traces to the resulting processor. Also created the "exported"Default*Functionsfunctions that can be used to provide a "subset" of the default functions used in the filter processor.Some details and context about this PR :
filterprocessor the user needs to create aNewFactoryproviding the custom OTTL functions.transformprocessor: [processor/transform] CreateWith*Functionsfactory options to provide custom OTTL funcs programatically. #39966.Additional*Funcsconfig properties to provide additional OTTL funcs programatically. #39641 (comment) .Usage
The factory options can be used like the following example :
Link to tracking issue
Testing
Documentation
With*Functions,Default*FunctionsandNewFactoryWithOptionsfunctions.